Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1301

thrift: consolidate common code in TNonblockingServer

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From eb29276e934e6d445fb3226da9cb81b890be5cb7 Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Fri, 16 Apr 2010 01:28:36 +0000
      Subject: [PATCH 21/33] thrift: consolidate common code in TNonblockingServer
      constructors

      Summary:
      This moves most of the code in the initializer lists into a helper
      function. I'm about to make a change that will double the number of
      constructors, and I'd rather not have to copy-and-paste these long
      initializers.

      Test Plan:
      Ran the tests from [fb unit test], and everything passes.

      Revert Plan:
      OK


      lib/cpp/src/server/TNonblockingServer.h | 125 ++++++++++++------------------
      1 files changed, 50 insertions, 75 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: