Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1284

thrift: fix processor inheritance

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From fa7a7d7fb25f13e7f375f21b91ed119d84cebc04 Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Sat, 3 Apr 2010 02:49:45 +0000
      Subject: [PATCH 13/33] thrift: fix processor inheritance

      Summary:
      I don't see any reason why all of the generated processor classes
      multiply inherit from TProcessor via all of their parent classes.
      This eliminates the virtual inheritance by changing the code so that
      only the first class in the heirarchy inherits from TProcessor or
      TAsyncProcessor.

      As part of this change, we now have to explicitly write
      "this->eventHandler_" instead of just "eventHandler_" so that the
      compiler can tell that this is an inherited member variable when we are
      generating template code.

      Test Plan:
      Built [internal fb thing] and a few other projects, and everything compiled fine.
      I haven't done much actual RPC testing.

      Revert Plan:
      OK

      Conflicts:

      compiler/cpp/src/generate/t_cpp_generator.cc

      compiler/cpp/src/generate/t_cpp_generator.cc | 91 +++++++++++++-------------
      1 files changed, 46 insertions, 45 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: