[THRIFT-1232] JavaScript TException should be a constructor function

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: JavaScript - Library
• Labels: exception-handling js
• Assignee: Pascal Bach
• Reporter: Pascal Bach
• Created: 06/Jul/11 07:31
• Updated: 01/Nov/11 02:54
• Resolved: 08/Jul/11 12:47

Description

The JavaScript TException is declared as an object with a prototype property assigned to it.
It should be declared as a constructor function with a prototype. Otherwise exceptions derived from TException using Thrift.inherits are not instances of TException.

Example:
function DerivedException() {};
Thrift.inherits(DerivedException, Thrift.TException);
var ex = new DerivedException();
ex instanceof Thrift.TException // => Error as TException is not a function