Thrift
  1. Thrift
  2. THRIFT-1215

Undefined property Thirft in lib/js/thrift.js

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: JavaScript - Library
    • Labels:
      None

      Description

      This is a simple typo - line 726 of ilb/js/thrift.js

      Thirft instead of thrift.

        Activity

        Hide
        Roger Meier added a comment -

        Hi David

        I cannot find such a typo in trunk, see:
        http://svn.apache.org/viewvc/thrift/trunk/lib/js/thrift.js?view=markup

        Do you use an older version?

        -Roger

        Show
        Roger Meier added a comment - Hi David I cannot find such a typo in trunk, see: http://svn.apache.org/viewvc/thrift/trunk/lib/js/thrift.js?view=markup Do you use an older version? -Roger
        Hide
        David Miller added a comment -

        Hi Roger

        Sorry - should have included that in my report.

        This is from 0.6.1 stable as downloaded from http://www.apache.org/dyn/closer.cgi?path=/thrift/0.6.1/thrift-0.6.1.tar.gz

        tar -xvf thrift-0.6.1.tar.gz
        ...snip...
        cd thrift-0.6.1/
        grep -n Thirft lib/js/thrift.js
        => 726:Thirft.inherits = function(constructor, superConstructor) {

        It seems that there has been some refactoring done that's fixed this in between versions

        Show
        David Miller added a comment - Hi Roger Sorry - should have included that in my report. This is from 0.6.1 stable as downloaded from http://www.apache.org/dyn/closer.cgi?path=/thrift/0.6.1/thrift-0.6.1.tar.gz tar -xvf thrift-0.6.1.tar.gz ...snip... cd thrift-0.6.1/ grep -n Thirft lib/js/thrift.js => 726:Thirft.inherits = function(constructor, superConstructor) { It seems that there has been some refactoring done that's fixed this in between versions
        Hide
        Roger Meier added a comment -

        Thanks for update, I recommend to switch to a more recent version of the javascript implementation, there where a few bugs.

        Show
        Roger Meier added a comment - Thanks for update, I recommend to switch to a more recent version of the javascript implementation, there where a few bugs.

          People

          • Assignee:
            Roger Meier
            Reporter:
            David Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.05h
              0.05h
              Remaining:
              Remaining Estimate - 0.05h
              0.05h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development