Thrift
  1. Thrift
  2. THRIFT-1205

port server unduly fragile with arbitrary input

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.6.1
    • Fix Version/s: 0.8
    • Component/s: Java - Library
    • Labels:
    • Environment:

      javac 1.5.0_19, OS X 10.4.11

    • Patch Info:
      Patch Available

      Description

      Telnetting to the port and type a couple of arbitrary characters crashes the server almost immediately as follows. I haven't glanced at the relevant code. Is this reproducible on other platforms?

      $ ./run-server.sh 
      Starting the simple server...
      Exception in thread "Thread-0" java.lang.OutOfMemoryError: Java heap space
              at org.apache.thrift.protocol.TBinaryProtocol.readStringBody(TBinaryProtocol.java:353)
              at org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:215)
              at SimonSays$Processor.process(Unknown Source)
              at org.apache.thrift.server.TSimpleServer.serve(TSimpleServer.java:70)
              at JavaServer.simple(Unknown Source)
              at JavaServer$1.run(Unknown Source)
              at java.lang.Thread.run(Thread.java:613)
      

        Activity

        Bryan Duxbury made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 0.8 [ 12316293 ]
        Resolution Fixed [ 1 ]
        Ryan King made changes -
        Patch Info [Patch Available]
        Ryan King made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        Ryan King made changes -
        Ryan King made changes -
        Resolution Duplicate [ 3 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Ryan King [ kingryan ]
        Bryan Duxbury made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Duplicate [ 3 ]
        Toby Thain created issue -

          People

          • Assignee:
            Ryan King
            Reporter:
            Toby Thain
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development