[THRIFT-1176] Thrift compiler global leakage js

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.6
• Component/s: Node.js - Compiler
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Dan Di Spaltro
• Created: 20/May/11 23:04
• Updated: 01/Nov/11 02:53
• Resolved: 22/May/11 10:03

Description

Below I added the var qualifier on the declare field function. This is fairly trivial and fixes the global scope leak.

 
diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc
index a654fc9..c4f201f 100644
--- a/compiler/cpp/src/generate/t_js_generator.cc
+++ b/compiler/cpp/src/generate/t_js_generator.cc
@@ -1623,7 +1623,7 @@ string t_js_generator::declare_field(t_field* tfield, bool init, bool obj) {
   string result = "this." + tfield->get_name();
 
   if(!obj){
-      result = tfield->get_name();
+      result = "var " + tfield->get_name();
   }
 
   if (init) {