Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1175

Bad data can cause TProtocolUtil.skip to take a lot of CPU in a do-nothing loop

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Java - Library
    • None

    Description

      If, due to bad data, skip gets to the LIST case with a large size and invalid elemType, it loops doing nothing (since nothing happens in the recursive call to skip with an invalid elemType), taking a lot of CPU. Same for the MAP and SET cases.

      The default case in skip should throw a TProtocolException so invalid elemTypes are caught.

      Attachments

        Activity

          People

            Unassigned Unassigned
            jaked Jake Donham
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: