[THRIFT-1082] Thrift::FramedTransport sometimes calls close() on an undefined value

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9
• Component/s: Perl - Library

Environment

CentOS release 5.4 (x86_64), perl 5.8.8

• Patch Info: Patch Available
• Assignee: John Siracusa
• Reporter: John Siracusa
• Created: 03/Mar/11 16:06
• Updated: 28/Sep/12 12:45
• Resolved: 28/Sep/12 12:11

Description

The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:

(in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.

The attached patch is a simple workaround to the problem.