Thrift
  1. Thrift
  2. THRIFT-1080

erlang test's 'make' fails on Mac OSX

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: Erlang - Library
    • Labels:
      None

      Description

      [bryanduxbury erl]$make
      rm -rf gen
      ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
      ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
      mkdir -p gen/include
      mkdir -p gen/src
      mkdir -p gen/ebin
      mv -t gen/include gen-erl/*.hrl
      mv: illegal option -- t
      usage: mv [-f | -i | -n] [-v] source target
             mv [-f | -i | -n] [-v] source ... directory
      make: *** [gen] Error 64
      
      

        Activity

        Bryan Duxbury created issue -
        Bryan Duxbury made changes -
        Field Original Value New Value
        Component/s Erlang - Library [ 12312390 ]
        Hide
        JCF added a comment -

        changes the move call in erlang test case to use mv SOURCE DEST rather than specifying a target

        Show
        JCF added a comment - changes the move call in erlang test case to use mv SOURCE DEST rather than specifying a target
        JCF made changes -
        Attachment thrift-1080.patch [ 12474441 ]
        Hide
        Bryan Duxbury added a comment -

        Your patch is definitely an improvement, but:

        [bryanduxbury erl]$make
        mkdir -p ebin
        erlc  -Igen/include -Iinclude -I../../lib/erl/include -o ebin src/test_server.erl
        src/test_server.erl:144: undefined macro 'thriftTest_EIGHT'
        src/test_server.erl:22: function handle_function/2 undefined
        make: *** [ebin/test_server.beam] Error 1
        
        Show
        Bryan Duxbury added a comment - Your patch is definitely an improvement, but: [bryanduxbury erl]$make mkdir -p ebin erlc -Igen/include -Iinclude -I../../lib/erl/include -o ebin src/test_server.erl src/test_server.erl:144: undefined macro 'thriftTest_EIGHT' src/test_server.erl:22: function handle_function/2 undefined make: *** [ebin/test_server.beam] Error 1
        Hide
        JCF added a comment -

        My patch will fix the build issue, but there is a problem with the erlang test code. The test cases look like they are missing a file. None of the tests in the src folder can compile due to the missing thriftTest_# macros and these macros are no where to be found in the source.

        Anthony, Chris, Todd, can one of you take a look at this

        Show
        JCF added a comment - My patch will fix the build issue, but there is a problem with the erlang test code. The test cases look like they are missing a file. None of the tests in the src folder can compile due to the missing thriftTest_# macros and these macros are no where to be found in the source. Anthony, Chris, Todd, can one of you take a look at this
        Hide
        Anthony Molinaro added a comment -

        The way enumerations were generated changed at some point, but the test code was not up to date. I fixed the compile issues and commited the changes along with your patch.

        Show
        Anthony Molinaro added a comment - The way enumerations were generated changed at some point, but the test code was not up to date. I fixed the compile issues and commited the changes along with your patch.
        Hide
        Anthony Molinaro added a comment -

        Merged in patch plus a few changes required to have these compile.

        Show
        Anthony Molinaro added a comment - Merged in patch plus a few changes required to have these compile.
        Anthony Molinaro made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Anthony Molinaro [ djnym ]
        Fix Version/s 0.7 [ 12315360 ]
        Resolution Fixed [ 1 ]
        Hide
        Anthony Molinaro added a comment -

        I just realized why this bug felt so familiar, I fixed the exact same problems in the tutorial directory a month or so ago

        I did a few finds and don't see any more examples of the use of mv -t.

        Show
        Anthony Molinaro added a comment - I just realized why this bug felt so familiar, I fixed the exact same problems in the tutorial directory a month or so ago I did a few finds and don't see any more examples of the use of mv -t.
        Bryan Duxbury made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Thrift #100 (See https://hudson.apache.org/hudson/job/Thrift/100/)
        THRIFT-1080 : fix building of test code

        Show
        Hudson added a comment - Integrated in Thrift #100 (See https://hudson.apache.org/hudson/job/Thrift/100/ ) THRIFT-1080 : fix building of test code
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        21d 22h 17m 1 Anthony Molinaro 24/Mar/11 16:48
        Resolved Resolved Closed Closed
        11m 18s 1 Bryan Duxbury 24/Mar/11 16:59

          People

          • Assignee:
            Anthony Molinaro
            Reporter:
            Bryan Duxbury
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development