Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: AS3 - Compiler
    • Labels:
      None

      Description

      Would be nice to have i64 support for AS3. Although it's not straight forward.

      Found a previous bit of discussion about AS3 i64 support here:
      http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3ab3d@mail.gmail.com%3e

        Activity

        Hide
        Ethan Urie added a comment -

        Adding 64-bit AS3 support via as3crypto's BigInteger

        Show
        Ethan Urie added a comment - Adding 64-bit AS3 support via as3crypto's BigInteger
        Hide
        Ethan Urie added a comment -

        I've attached a patch with 64-bit support via as3crypto's BigInteger.

        I've also added a serializer and deserializer as well as a memory buffer.

        Also fixed some casting in generated code.

        To build, it expects as3crypto.swc to be in <thrift-trunk>/lib/as3/lib.

        Show
        Ethan Urie added a comment - I've attached a patch with 64-bit support via as3crypto's BigInteger. I've also added a serializer and deserializer as well as a memory buffer. Also fixed some casting in generated code. To build, it expects as3crypto.swc to be in <thrift-trunk>/lib/as3/lib.
        Hide
        Roger Meier added a comment -

        comitted

        Show
        Roger Meier added a comment - comitted
        Hide
        Hudson added a comment -

        Integrated in Thrift #434 (See https://builds.apache.org/job/Thrift/434/)
        THRIFT-1079 Support i64 in AS3
        Patch: Ethan Urie (Revision 1325048)

        Result = SUCCESS
        roger : http://svn.apache.org/viewvc/?view=rev&rev=1325048
        Files :

        • /thrift/trunk/compiler/cpp/src/generate/t_as3_generator.cc
        • /thrift/trunk/lib/as3/build.xml
        • /thrift/trunk/lib/as3/src/org/apache/thrift/TDeserializer.as
        • /thrift/trunk/lib/as3/src/org/apache/thrift/TSerializer.as
        • /thrift/trunk/lib/as3/src/org/apache/thrift/protocol/TBinaryProtocol.as
        • /thrift/trunk/lib/as3/src/org/apache/thrift/protocol/TProtocol.as
        • /thrift/trunk/lib/as3/src/org/apache/thrift/transport/TMemoryBuffer.as
        Show
        Hudson added a comment - Integrated in Thrift #434 (See https://builds.apache.org/job/Thrift/434/ ) THRIFT-1079 Support i64 in AS3 Patch: Ethan Urie (Revision 1325048) Result = SUCCESS roger : http://svn.apache.org/viewvc/?view=rev&rev=1325048 Files : /thrift/trunk/compiler/cpp/src/generate/t_as3_generator.cc /thrift/trunk/lib/as3/build.xml /thrift/trunk/lib/as3/src/org/apache/thrift/TDeserializer.as /thrift/trunk/lib/as3/src/org/apache/thrift/TSerializer.as /thrift/trunk/lib/as3/src/org/apache/thrift/protocol/TBinaryProtocol.as /thrift/trunk/lib/as3/src/org/apache/thrift/protocol/TProtocol.as /thrift/trunk/lib/as3/src/org/apache/thrift/transport/TMemoryBuffer.as
        Hide
        Jake Farrell added a comment -

        -1 for this patch, It introduces a dependency which is not publicly available via maven and will break our ability to push this to maven central for the next release

        Show
        Jake Farrell added a comment - -1 for this patch, It introduces a dependency which is not publicly available via maven and will break our ability to push this to maven central for the next release
        Hide
        Ethan Urie added a comment -

        FWIW, there is a public Maven repo that is hosting as3crypto at: http://mlepicki.github.com/maven-repository/repository

        Show
        Ethan Urie added a comment - FWIW, there is a public Maven repo that is hosting as3crypto at: http://mlepicki.github.com/maven-repository/repository
        Hide
        Jake Farrell added a comment -

        reverted until this can be reworked to not break the release

        Show
        Jake Farrell added a comment - reverted until this can be reworked to not break the release
        Hide
        Hudson added a comment -

        Integrated in Thrift #461 (See https://builds.apache.org/job/Thrift/461/)
        Thrift-1079:Support i64 in AS3
        Client: as3
        Patch: Reverting

        Reverting patch due to usage of non public library which breaks ability to export as3 client to maven central during a release. (Revision 1337007)

        Result = SUCCESS

        Show
        Hudson added a comment - Integrated in Thrift #461 (See https://builds.apache.org/job/Thrift/461/ ) Thrift-1079:Support i64 in AS3 Client: as3 Patch: Reverting Reverting patch due to usage of non public library which breaks ability to export as3 client to maven central during a release. (Revision 1337007) Result = SUCCESS
        Hide
        Jens Geyer added a comment -

        Removed the patch available flag, as the patch seems not sufficient.

        Show
        Jens Geyer added a comment - Removed the patch available flag, as the patch seems not sufficient.
        Hide
        Will Warren added a comment -

        Has there been any movement on this? Will we see this in 1.0 as planned?

        Show
        Will Warren added a comment - Has there been any movement on this? Will we see this in 1.0 as planned?
        Hide
        Jake Farrell added a comment -

        comments from earlier still stand. It introduces a dependency which is not publicly available via maven and will break our ability to push this to maven central, having a random github repo containing the library is not a viable long term option and should not be used

        Show
        Jake Farrell added a comment - comments from earlier still stand. It introduces a dependency which is not publicly available via maven and will break our ability to push this to maven central, having a random github repo containing the library is not a viable long term option and should not be used
        Hide
        Will Warren added a comment -

        It's only a few classes, maybe we can reach out to the developer and see if they would mind them being included in the Thrift trunk?

        Show
        Will Warren added a comment - It's only a few classes, maybe we can reach out to the developer and see if they would mind them being included in the Thrift trunk?
        Hide
        Jake Farrell added a comment -

        Closing as this has been open for awhile now with no traction. If we can get the BigInteger code from the as3crypto library contributed from the original author for use by Apache Thrift or if they pull that out into a publicly available jar then I see no reason to not reopen this ticket

        Show
        Jake Farrell added a comment - Closing as this has been open for awhile now with no traction. If we can get the BigInteger code from the as3crypto library contributed from the original author for use by Apache Thrift or if they pull that out into a publicly available jar then I see no reason to not reopen this ticket

          People

          • Assignee:
            Jake Farrell
            Reporter:
            Rowan Kerr
          • Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development