[THRIFT-1055] csharp TServerSocket and TSocket do not disable Nagle via Socket.NoDelay = true like cpp and java do

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: C# - Library

Environment

Kubuntu Maverick (10.10)

• Patch Info: Patch Available
• Assignee: Chris Morgan
• Reporter: Chris Morgan
• Created: 08/Feb/11 15:35
• Updated: 08/Feb/11 16:39
• Resolved: 08/Feb/11 16:39

Description

https://issues.apache.org/jira/browse/THRIFT-904 resulted in TFramedTransport being improved so it wasn't necessary to disable Nagle.

For the case of TServerSocket and TSocket, a simple server case, performance is still very poor, ~30 msg/sec vs. ~11k msg/sec with NoDelay = true.

Java and cpp disable nagle in their TSocket and TServerSocket implementations and performance is MUCH improved with nagle disabled for csharp so I'm proposing that csharp should also disable nagle.