[THRIFT-1038] Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializable

• Type: Sub-task
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.3, 0.4, 0.5
• Fix Version/s: 0.6, 0.7
• Component/s: Java - Compiler

Environment

All

• Assignee: Mathias Herberts
• Reporter: Mathias Herberts
• Created: 13/Jan/11 06:17
• Updated: 11/Jan/16 09:51
• Resolved: 26/Jan/11 22:46

Description

Since THRIFT-830, binary fields are implemented using ByteBuffer instead of byte[], but ByteBuffer are not serializable (in the Java sense), therefore the generated Java classes are not serializable either.

Even though one might expect the Thrift serialization to be used instead of Java serialization, there are situations where the serialization of the classes is not in the hands of the user (think for example about the HttpSession offline storage done in Tomcat), therefore we MUST generate Java classes that are serializable in the Java sense.

I'm finishing up a compiler patch to generate writeObject/readObject methods that will make the generated classes Serializable again, will submit it tonight.

Issue Links

• breaks: THRIFT-1146 Android Incompatibility : in Android < 2.3 java.io.IOException doesn't support for Throwable parameter in constructor
• breaks: THRIFT-1226 command line option to disable overriding java serialization
• relates to: THRIFT-3543 Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializable