Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1031

Patch to compile Thrift for vc++ 9.0 and 10.0

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      Windows XP 32bit, vc++ 9.0, 10.0

    • Patch Info:
      Patch Available

      Description

      At our company we need clients running on Windows being able to connect to our linux servers running hypertable. The attached patch enables the parts needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 10.0 compilers.

      Having read previous posts about ports using boost::asio we found these to be too intrusive for our needs. This version uses pthreads_win32 and winsock2 and is as designed to be as un-intrusive as is possible to the original unix code base. It is mostly #defines between unix sockets and winsock2 sockets. We also tried to follow the folder structuring of the C# runtime that has visual studio solutions to be consistent.

      More details are in the README as not all the functionality of the original unix code base is available to windows users. We will add the missing functionality, we just wanted to share what we had as for a Windows based client for us it is sufficient.

      The patch is based on the latest revision in SVN, we would love feedback and any code reviews. If there is any possibility of this being added to the main trunk then that would be much appreciated, however we don't expect that.

        Attachments

        1. PosixThreadFactory.patch
          0.9 kB
          Peace C
        2. thrift_msvc_v0_7.patch
          55 kB
          James Dickson
        3. thrift_msvc_v0_6.patch
          83 kB
          James Dickson
        4. thrift_msvc_v0_5.patch
          81 kB
          James Dickson
        5. thrift_msvc_v0_4.patch
          81 kB
          James Dickson
        6. thrift_msvc_v0_3.patch
          97 kB
          James Dickson
        7. thrift_msvc_v0_2.patch
          294 kB
          James Dickson
        8. thrift_msvc_v0_1.patch
          77 kB
          James Dickson
        9. thrift_msvc.patch
          40 kB
          James Dickson

          Issue Links

            Activity

              People

              • Assignee:
                roger.meier Roger Meier
                Reporter:
                jamesd James Dickson
              • Votes:
                5 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: