Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1025

C++ ServerSocket should inherit from Socket with the necessary Ctor to listen on connections from a specific host (similar to perl library)

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.3
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      any

      Description

      Perl library ServerSocket inherits from Socket the ctor ServerSocket->new( addr, port) which enables to accept the connections from specified host only (for security reasons for instance).

      package Thrift::ServerSocket;
      use Socket qw(IPPROTO_TCP TCP_NODELAY);
      use base qw( Thrift::Socket Thrift::ServerTransport );

      while surprisingly C++ ServerSocket omits inheriting from Socket.
      class TServerSocket : public TServerTransport {

      Regards.
      Valery.

        Attachments

        1. THRIFT-1025.patch
          10 kB
          James E. King III

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                kreidenko@f5.com Valery Kreidenko
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: