[THRIFT-1003] Polishing c_glib code

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.6
• Assignee: Anatol Pomozov
• Reporter: Anatol Pomozov
• Created: 22/Nov/10 19:56
• Updated: 01/Nov/11 02:51
• Resolved: 26/Nov/10 10:18

Description

attached patch contains following changes:

• Added Apache headers to c/h files
• Use gtester for running tests. We don't need -wrapper script anymore
• Use one-line macros G_DEFINE_TYPE instead of 15-line class definition
• Keep formatting closer to glib-like style (one line class definition macroses/remove trailing spaces)

Given changes are mostly fixing low hanging fruits. It does not change any logic/api.

There are more chages needed, such as

• using CLASS_TYPE_new functions instead of g_object_new(CLASS_TYPE)
• stop using _set_property (aka reflection) in constructors
• check more careful about _ref and _unref handling

but this requires more careful refactoring so it will be later in a separate patch.