[TEZ-2857] Flakey tests in TestDAGImpl

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.4.0
• Fix Version/s: 0.7.1, 0.8.1-alpha
• Target Version/s: 0.7.1
• Assignee: Siddharth Seth
• Reporter: Siddharth Seth
• Created: 24/Sep/15 23:31
• Updated: 12/Oct/15 20:46
• Resolved: 29/Sep/15 00:53

Description

testDAGKill

java.lang.AssertionError: expected:<6> but was:<5>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.junit.Assert.assertEquals(Assert.java:542)
	at org.apache.tez.dag.app.dag.impl.TestDAGImpl.testDAGKill(TestDAGImpl.java:1880)

testDAGKillPending

java.lang.AssertionError: expected:<5> but was:<3>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.junit.Assert.assertEquals(Assert.java:542)
	at org.apache.tez.dag.app.dag.impl.TestDAGImpl.testDAGKillPending(TestDAGImpl.java:1916)

There's a race between vertex success and vertex terminate reaching the vertices, which cause the tests to be flakey.