Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2135

ACL checks handled incorrectly in AMWebController

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: None
    • Labels:
      None

      Description

          if (callerUGI != null && appContext.getAMACLManager().checkDAGViewAccess(callerUGI)) {
            return false;
          }
      

      Check returns false if user has access.

      1. TEZ-2135.1.patch
        5 kB
        Hitesh Shah
      2. TEZ-2135.2.patch
        5 kB
        Hitesh Shah

        Activity

        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.
        Hide
        hitesh Hitesh Shah added a comment -

        Thanks for the review Prakash Ramachandran. Committed.

        Show
        hitesh Hitesh Shah added a comment - Thanks for the review Prakash Ramachandran . Committed.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 LGTM

        Show
        pramachandran Prakash Ramachandran added a comment - +1 LGTM
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700268/TEZ-2135.2.patch
        against master revision c9a74d7.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/219//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/219//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700268/TEZ-2135.2.patch against master revision c9a74d7. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/219//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/219//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        Whitespace cleanup.

        Show
        hitesh Hitesh Shah added a comment - Whitespace cleanup.
        Hide
        hitesh Hitesh Shah added a comment - - edited
        Show
        hitesh Hitesh Shah added a comment - - edited Prakash Ramachandran Jonathan Eagles Mind taking a look?

          People

          • Assignee:
            hitesh Hitesh Shah
            Reporter:
            hitesh Hitesh Shah
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development