Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2134

TEZ UI: On request failure, display request URL and server name in error bar.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: None
    • Labels:
      None

      Description

      Adding simple text such as "Could not retrieve data from Timeline Server x.y.z:8188" would be way more useful.

      1. TEZ-2134.2.patch
        8 kB
        Sreenath Somarajapuram
      2. TEZ-2134.1.patch
        8 kB
        Sreenath Somarajapuram

        Activity

        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Prakash Ramachandran Please review the patch.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Prakash Ramachandran Please review the patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700250/TEZ-2134.1.patch
        against master revision c9a74d7.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/217//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/217//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700250/TEZ-2134.1.patch against master revision c9a74d7. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/217//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/217//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 LGTM
        one minor comment - the patched ajax.beforeSend can be moved to a common function.this can be taken up in another jira for moving the common functionality of adapters to a common class.

        Show
        pramachandran Prakash Ramachandran added a comment - +1 LGTM one minor comment - the patched ajax.beforeSend can be moved to a common function.this can be taken up in another jira for moving the common functionality of adapters to a common class.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        cancelling patch as this causes a conflict with beforesend in ambari view - which disables proxy

        Show
        pramachandran Prakash Ramachandran added a comment - cancelling patch as this causes a conflict with beforesend in ambari view - which disables proxy
        Hide
        Sreenath Sreenath Somarajapuram added a comment - - edited

        The patch uses ajaxPrefilter instead of overriding ajaxOptions and setting beforeSend.

        Tested over Ambari.
        Prakash Ramachandran Please review.

        Show
        Sreenath Sreenath Somarajapuram added a comment - - edited The patch uses ajaxPrefilter instead of overriding ajaxOptions and setting beforeSend. Tested over Ambari. Prakash Ramachandran Please review.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700782/TEZ-2134.2.patch
        against master revision 088f92d.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/226//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/226//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700782/TEZ-2134.2.patch against master revision 088f92d. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/226//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/226//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        Sreenath Somarajapuram patch looks good. one question though, prefilters fire before the beforesend event - so in case the url is modified in beforesend event - this would not be visible in the error message?
        eg. ambari proxying the url - I believe it would show http://timelineserver/entitypath instead of http://ambari/path?proxy=http://timelineserver/entitypath ?
        is this expected?

        Show
        pramachandran Prakash Ramachandran added a comment - Sreenath Somarajapuram patch looks good. one question though, prefilters fire before the beforesend event - so in case the url is modified in beforesend event - this would not be visible in the error message? eg. ambari proxying the url - I believe it would show http://timelineserver/entitypath instead of http://ambari/path?proxy=http://timelineserver/entitypath ? is this expected?
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Yes, as expected.
        Feel the exact url is more readable for user than its encoded form that we use in proxy.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Yes, as expected. Feel the exact url is more readable for user than its encoded form that we use in proxy.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 lgtm

        Show
        pramachandran Prakash Ramachandran added a comment - +1 lgtm
        Hide
        hitesh Hitesh Shah added a comment -

        Thanks Sreenath Somarajapuram. Committed.

        Show
        hitesh Hitesh Shah added a comment - Thanks Sreenath Somarajapuram . Committed.
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development