Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2112

Tez UI: fix offset calculation, add home button to breadcrumbs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: None
    • Labels:
      None

      Description

      Clear issue relating to offset calculation.
      Add Home button in book mark

      1. TEZ-2112.2.patch
        6 kB
        Sreenath Somarajapuram
      2. TEZ-2112.1.patch
        6 kB
        Sreenath Somarajapuram

        Activity

        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Prakash Ramachandran Please review the patch.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Prakash Ramachandran Please review the patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12699091/TEZ-2112.1.patch
        against master revision b6cb7f8.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/196//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/196//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699091/TEZ-2112.1.patch against master revision b6cb7f8. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/196//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/196//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -
        • if container offset is not available then container height is not set.
          minor nit: the home icon could be bigger.

        rest looks good.

        Show
        pramachandran Prakash Ramachandran added a comment - if container offset is not available then container height is not set. minor nit: the home icon could be bigger. rest looks good.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thanks for the comments, please find the patch attached.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Thanks for the comments, please find the patch attached.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12699216/TEZ-2112.2.patch
        against master revision b6cb7f8.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/198//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/198//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699216/TEZ-2112.2.patch against master revision b6cb7f8. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/198//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/198//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 LGTM.

        Show
        pramachandran Prakash Ramachandran added a comment - +1 LGTM.
        Hide
        hitesh Hitesh Shah added a comment -
        Show
        hitesh Hitesh Shah added a comment - Thanks Sreenath Somarajapuram and Prakash Ramachandran . Committed.
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development