Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2078

Tez UI: Task logs url use in-progress url causing various errors

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None

      Description

      The download link when pointing to the in-progress URL will not work in most cases as the downloaded page is the link to the NM which internally redirects to the job history. This means that the downloaded file will not have any actual log contents.

      Possible solutions:

      • only show download button when an application has completed. Please note that this is for when a yarn app has completed. A completed DAG has no guarantee that its logs are available for download.
      • download link should always only rely on completed log url and never on in-progress url
      • view logs link can always point to in-progress url as it will automatically redirect to the jobhistory logs url if the container has completed.
      1. TEZ-2078.1.patch
        18 kB
        Sreenath Somarajapuram
      2. TEZ-2078.2.patch
        18 kB
        Sreenath Somarajapuram

        Activity

        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.
        Hide
        hitesh Hitesh Shah added a comment -

        Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram

        Show
        hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698165/TEZ-2078.2.patch
        against master revision b336ca0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/172//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/172//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698165/TEZ-2078.2.patch against master revision b336ca0. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/172//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/172//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 lgtm

        Show
        pramachandran Prakash Ramachandran added a comment - +1 lgtm
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thanks Prakash Ramachandran, attaching a new patch with the typo fixed.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Thanks Prakash Ramachandran , attaching a new patch with the typo fixed.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698160/TEZ-2078.1.patch
        against master revision b336ca0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in :
        org.apache.tez.dag.app.TestPreemption

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/171//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/171//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698160/TEZ-2078.1.patch against master revision b336ca0. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in : org.apache.tez.dag.app.TestPreemption Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/171//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/171//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        overall patch looks fine

        donwload => download

        {{#if view.cellContent.donwloadUrl}}\
        
        Show
        pramachandran Prakash Ramachandran added a comment - overall patch looks fine donwload => download {{# if view.cellContent.donwloadUrl}}\
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Attaching patch for following tables.
        Dag > Tasks
        Dag > Task Attempts
        Vertex > Tasks
        Vertex > Task Attempts
        Task > Task Attempts

        Prakash Ramachandran Please review the patch.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Attaching patch for following tables. Dag > Tasks Dag > Task Attempts Vertex > Tasks Vertex > Task Attempts Task > Task Attempts Prakash Ramachandran Please review the patch.

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development