Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2043

Tez UI: add progress info from am webservice to dag and vertex views

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None
    • Target Version/s:

      Description

      TEZ-2018 exposes progress info about dag, vertex etc. it would be useful if the ui could show progress info in the dag view

      1. TEZ-2043.1.patch
        22 kB
        Prakash Ramachandran
      2. TEZ-2043.2.patch
        22 kB
        Prakash Ramachandran

        Issue Links

          Activity

          Hide
          pramachandran Prakash Ramachandran added a comment - - edited

          Sreenath Somarajapuram can you have a look. depends on patch for TEZ-2018, yet to be checked in, but a early review could be useful.

          Show
          pramachandran Prakash Ramachandran added a comment - - edited Sreenath Somarajapuram can you have a look. depends on patch for TEZ-2018 , yet to be checked in, but a early review could be useful.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          A trailing space in app.js, vertex_controller.js and dag_vertices.js

          Few suggestion:

          1. The following can be added into the fractionToPercentage function itself to reduce duplication.
          + var pct;
          + if (Ember.typeOf(this.get('progress')) === 'number')

          { + pct = App.Helpers.number.fractionToPercentage(this.get('progress')) + ' %'; + }

          + return pct;

          2. Same with the following snippet, it can be defined in one place (may be dag_controller.js) and reused from other places.
          + if (dag.get('status') === 'RUNNING') {
          + amInfoFetcher = store.find('dagProgress', dag.get('id'),

          { + appId: dag.get('applicationId'), + dagIdx: dag.get('idx') + }

          )
          + .then(function(dagProgressInfo)

          { + dag.set('progress', dagProgressInfo.get('progress')); + }

          )
          + .catch(function(error)

          { + Em.Logger.error('Failed to fetch dagProgress' + error); + }

          );
          + loaders.push(amInfoFetcher);
          + }

          Show
          Sreenath Sreenath Somarajapuram added a comment - A trailing space in app.js, vertex_controller.js and dag_vertices.js Few suggestion: 1. The following can be added into the fractionToPercentage function itself to reduce duplication. + var pct; + if (Ember.typeOf(this.get('progress')) === 'number') { + pct = App.Helpers.number.fractionToPercentage(this.get('progress')) + ' %'; + } + return pct; 2. Same with the following snippet, it can be defined in one place (may be dag_controller.js) and reused from other places. + if (dag.get('status') === 'RUNNING') { + amInfoFetcher = store.find('dagProgress', dag.get('id'), { + appId: dag.get('applicationId'), + dagIdx: dag.get('idx') + } ) + .then(function(dagProgressInfo) { + dag.set('progress', dagProgressInfo.get('progress')); + } ) + .catch(function(error) { + Em.Logger.error('Failed to fetch dagProgress' + error); + } ); + loaders.push(amInfoFetcher); + }
          Hide
          pramachandran Prakash Ramachandran added a comment -

          fixed the trailing spces and the fractionToPercentage function.

          for the reuse of the loading of progressinfo, the view for dags and app-dags can be reused as it is almost the same. will raise a new JIRA for that.

          Show
          pramachandran Prakash Ramachandran added a comment - fixed the trailing spces and the fractionToPercentage function. for the reuse of the loading of progressinfo, the view for dags and app-dags can be reused as it is almost the same. will raise a new JIRA for that.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          +1 LGTM

          Show
          Sreenath Sreenath Somarajapuram added a comment - +1 LGTM
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12697011/TEZ-2043.2.patch
          against master revision 5f3a9a3.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/139//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/139//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697011/TEZ-2043.2.patch against master revision 5f3a9a3. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/139//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/139//console This message is automatically generated.
          Hide
          hitesh Hitesh Shah added a comment -

          Committed to master and branch 0.6. Thanks Sreenath Somarajapuram and Prakash Ramachandran

          Show
          hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Sreenath Somarajapuram and Prakash Ramachandran
          Hide
          hitesh Hitesh Shah added a comment -

          Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          Show
          hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

            People

            • Assignee:
              pramachandran Prakash Ramachandran
              Reporter:
              pramachandran Prakash Ramachandran
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development