Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-1949

Whitelist TEZ_RUNTIME_OPTIMIZE_SHARED_FETCH for broadcast edges

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.6.0, 0.5.2, 0.7.0
    • Fix Version/s: 0.7.0, 0.5.4, 0.6.1
    • Component/s: None
    • Labels:
      None

      Description

      Tez configuration whitelisting is missing TEZ_RUNTIME_OPTIMIZE_SHARED_FETCH for broadcast edges (UnorderedKVInput).

      1. TEZ-1949.3.patch
        4 kB
        Gopal V
      2. TEZ-1949.2.patch
        3 kB
        Gopal V
      3. TEZ-1949.1.patch
        1.0 kB
        Gopal V

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12692335/TEZ-1949.1.patch
        against master revision adcfb84.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 findbugs. The patch appears to introduce 260 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/20//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-tests.html
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/20//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12692335/TEZ-1949.1.patch against master revision adcfb84. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 260 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/20//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/20//artifact/patchprocess/newPatchFindbugsWarningstez-tests.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/20//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        Should get this into 0.5.4 as well as 0.6.0 if possible.

        Show
        hitesh Hitesh Shah added a comment - Should get this into 0.5.4 as well as 0.6.0 if possible.
        Hide
        gopalv Gopal V added a comment -

        Test-case to confirm that we can set these parameters successfully.

        Show
        gopalv Gopal V added a comment - Test-case to confirm that we can set these parameters successfully.
        Hide
        rajesh.balamohan Rajesh Balamohan added a comment -

        +1. lgtm.

        Very minor comment. It is possible to set this using setConfiguration(Configuration conf). If needed, you can add it to the testcase (i.e adding TEZ_RUNTIME_OPTIMIZE_SHARED_FETCH to Configuration and invoking setFromConfiguration() in builder).

        Show
        rajesh.balamohan Rajesh Balamohan added a comment - +1. lgtm. Very minor comment. It is possible to set this using setConfiguration(Configuration conf). If needed, you can add it to the testcase (i.e adding TEZ_RUNTIME_OPTIMIZE_SHARED_FETCH to Configuration and invoking setFromConfiguration() in builder).
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12692691/TEZ-1949.2.patch
        against master revision 880d4f3.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 findbugs. The patch appears to introduce 68 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in :
        org.apache.tez.runtime.library.common.shuffle.TestFetcher

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/44//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/44//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12692691/TEZ-1949.2.patch against master revision 880d4f3. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 68 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in : org.apache.tez.runtime.library.common.shuffle.TestFetcher Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/44//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-internals.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/44//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/44//console This message is automatically generated.
        Hide
        gopalv Gopal V added a comment -

        Added the extra test.

        Show
        gopalv Gopal V added a comment - Added the extra test.
        Hide
        gopalv Gopal V added a comment -

        Committed to master and cherrypicked to branch-0.6 and branch-0.5.

        commit d676ef2ffb06e3a4debbd994a8880840e77180b9
        Author: Gopal V <gopalv@apache.org>
        Date: Fri Jan 16 14:19:15 2015 -0800

        TEZ-1949: Whitelist TEZ_RUNTIME_OPTIMIZE_SHARED_FETCH for broadcast edges. (gopalv)

        Show
        gopalv Gopal V added a comment - Committed to master and cherrypicked to branch-0.6 and branch-0.5. commit d676ef2ffb06e3a4debbd994a8880840e77180b9 Author: Gopal V <gopalv@apache.org> Date: Fri Jan 16 14:19:15 2015 -0800 TEZ-1949 : Whitelist TEZ_RUNTIME_OPTIMIZE_SHARED_FETCH for broadcast edges. (gopalv)
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12692830/TEZ-1949.3.patch
        against master revision 4974fb2.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 findbugs. The patch appears to introduce 64 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/49//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/49//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/49//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/49//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/49//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12692830/TEZ-1949.3.patch against master revision 4974fb2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 64 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/49//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/49//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/49//artifact/patchprocess/newPatchFindbugsWarningstez-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/49//artifact/patchprocess/newPatchFindbugsWarningstez-mapreduce.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/49//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            gopalv Gopal V
            Reporter:
            gopalv Gopal V
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development