[TEXT-37] Global vs local source of randomness

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0
• Labels: api constructor
• Assignee: Duncan Jones
• Reporter: Gilles Sadowski
• Created: 21/Dec/16 13:58
• Updated: 27/Dec/16 08:58
• Resolved: 27/Dec/16 08:58

Description

This is a follow-up of a discussion held in TEXT-34.

By default, RandomStringBuilder will use a shared java.util.Random object.

I think that the decision of which generator to use lies with the code that constructs the RandomStringBuilder instance, not with code that uses it (to build a string).
It would be safer to pass the RNG instance at construction (since, anyways, the constructor must be called):

RandomStringBuilder sb = new RandomStringBuilder(new MyRandom());
String s = sb.ofLength(length).build();

In the above, the MyRandom type is the subject of TEXT-36.

Issue Links

• supercedes: TEXT-34 Add class to generate random strings