[TEXT-111] WordUtils.wrap must calculate offset increment from wrapOn pattern length

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.7
• Assignee: Bruno P. Kinoshita
• Reporter: Michael Keppler
• Created: 09/Jan/18 10:19
• Updated: 03/Mar/19 21:36
• Resolved: 03/Mar/19 11:11

Description

WordUtils.wrap(...) allows to specify the "wrapOn" regular expression to be used as breakable characters. If this pattern is a zero width assertion or is longer than 1 charachter, then the output is wrong because the wrapping algorithm always skips one character (assuming the line break character has a width of 1).

Example failing test:

assertThat(WordUtils.wrap("abcdef", 2, "\n", false, "(?=d)")).isEqualTo("abc\ndef");
// produces "abc\nef" instead

Fix would be to change the 2 occurences of

offset = spaceToWrapAt + 1;

to

offset = spaceToWrapAt + matcher.end() - matcher.start();

thereby not advancing 1 character each time, but as many characters as were just matched.

Issue Links

• relates to: TEXT-152 infinite loop in WordUtils.wrap
• links to: GitHub Pull Request #104
• links to: pull request