Uploaded image for project: 'Tephra'
  1. Tephra
  2. TEPHRA-230

Improve the logic used to find recorded regions during invalid list pruning

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0-incubating
    • Fix Version/s: 0.12.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      During an invalid list pruning run, the plugin records the regions present on the HBase cluster at that time. It also records the count of regions as a checksum.

      While reading the list of recorded regions, if the checksum does not match the number of regions read at time t, then the plugin will move on to regions at time t - 1. However, the t-1 computation in inefficient today, and leads to microsecond decrements. It can be improved to use the time at which the current set of regions were recorded.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-tephra/pull/43

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/43
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user gokulavasan commented on the issue:

          https://github.com/apache/incubator-tephra/pull/43

          LGTM 👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user gokulavasan commented on the issue: https://github.com/apache/incubator-tephra/pull/43 LGTM 👍
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user poornachandra opened a pull request:

          https://github.com/apache/incubator-tephra/pull/43

          TEPHRA-230 Fix reading of saved regions during invalid pruning run

          JIRA - https://issues.apache.org/jira/browse/TEPHRA-230

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/poornachandra/incubator-tephra feature/fix-invalid-prune

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-tephra/pull/43.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #43


          commit 667144a99cd3863bf68982fb745d15786f294a92
          Author: poorna <poorna@cask.co>
          Date: 2017-05-17T00:47:15Z

          Port to other compat modules

          commit daf57aa167c0c6c240ba04642d0c328211cb1b20
          Author: poorna <poorna@cask.co>
          Date: 2017-05-17T00:51:32Z

          TEPHRA-230 Fix reading of saved regions during invalid pruning run


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user poornachandra opened a pull request: https://github.com/apache/incubator-tephra/pull/43 TEPHRA-230 Fix reading of saved regions during invalid pruning run JIRA - https://issues.apache.org/jira/browse/TEPHRA-230 You can merge this pull request into a Git repository by running: $ git pull https://github.com/poornachandra/incubator-tephra feature/fix-invalid-prune Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tephra/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit 667144a99cd3863bf68982fb745d15786f294a92 Author: poorna <poorna@cask.co> Date: 2017-05-17T00:47:15Z Port to other compat modules commit daf57aa167c0c6c240ba04642d0c328211cb1b20 Author: poorna <poorna@cask.co> Date: 2017-05-17T00:51:32Z TEPHRA-230 Fix reading of saved regions during invalid pruning run

            People

            • Assignee:
              poornachandra Poorna Chandra
              Reporter:
              poornachandra Poorna Chandra
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development