[TEPHRA-194] Transaction client should not retry startShort() if an invalid timeout is given

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0-incubating, 0.10.0-incubating
• Fix Version/s: 0.10.0-incubating
• Component/s: client
• Assignee: Andreas Neumann
• Reporter: Andreas Neumann
• Created: 17/Oct/16 22:46
• Updated: 08/Dec/16 21:14
• Resolved: 08/Dec/16 21:14

Description

Currently, if an invalid timeout (negative, or too long) is given, the Tx manager throws an IllegalArgumentException. The thrift client will catch that and apply the retry strategy. However, in this case, retry is pointless, and if the strategy is, for example, exponential backoff, if introduces unneccessary load and latency.

The service should instead throw a meaningful exception for that, so that the client knows not to retry.

Issue Links

• links to: GitHub Pull Request #18