[TAVERNA-968] Update/remove custom executeworkflow.sh in Taverna Server

• Type: Bug
• Status: Done
• Priority: Blocker
• Resolution: Done
• Fix Version/s: command-line 3.1.0
• Component/s: Taverna Command-line Tool, Taverna Server
• Assignee: Unassigned
• Reporter: Stian Soiland-Reyes
• Created: 07/May/16 11:17
• Updated: 13/May/16 15:18
• Resolved: 13/May/16 15:18

Description

https://builds.apache.org/user/stain/my-views/view/taverna/job/incubator-taverna-server/136/console

failed with

[INFO] --- exec-maven-plugin:1.2.1:exec (improve-registry-coverage) @ taverna-server-webapp ---

Error: Unable to access jarfile /home/jenkins/jenkins-slave/workspace/incubator-taverna-server/taverna-server-webapp/target/TavernaServer.3.1.0-incubating-SNAPSHOT/WEB-INF/classes/util/taverna-command-line-3.1.0-incubating-SNAPSHOT/lib/taverna-command-line-0.1.1.jar

It seems there is a custom executeworkflow.sh in

https://github.com/apache/incubator-taverna-server/blob/master/taverna-server-webapp/src/main/replacementscripts/executeworkflow.sh

Do we still need that? in which case the path should be updated to the equivalent of lib/org.apache.taverna.commandline.taverna-commandline-api-3.1.0-incubating-SNAPSHOT.jar

Or should we not rather add whatever special it adds to the "proper" executeworkflow.sh in Taverna Command Line now before the release? (I've set this as a blocker for the 3.1.0 Command Line)

Is it lines like this?

RUNID_PROP= 
if test x != "x$TAVERNA_RUN_ID"; then
    RUNID_PROP="-Dtaverna.runid=$TAVERNA_RUN_ID"
fi
INTERACTION_PROPS=-Dtaverna.interaction.ignore_requests=true