Tapestry
  1. Tapestry
  2. TAPESTRY-980

in ExternalService, activate the external page before validating

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 4.1
    • Fix Version/s: 4.1.1
    • Component/s: Framework
    • Labels:
      None

      Description

      An issue with the validate() method of IPage and ExternalPages is that the validate() gets called before the method "activateExternalPage". This makes any validation often impossible or useless because the properties get often set during the activateExternalPage method.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          188d 1 Jesse Kuhnert 11/Dec/06 00:20
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12567780 ] jira [ 12590908 ]
          Mark Thomas made changes -
          Workflow jira [ 12372861 ] Default workflow, editable Closed status [ 12567780 ]
          Jesse Kuhnert made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          Hide
          Jesse Kuhnert added a comment -

          Going to resolve this one for now. If there is a good reason why security would be based around something happening in activateExternalPage we may need to enhance that specific method or add a new one somehow but I don't currently see where this makes sense with the documented behavior of the existing listeners.

          Show
          Jesse Kuhnert added a comment - Going to resolve this one for now. If there is a good reason why security would be based around something happening in activateExternalPage we may need to enhance that specific method or add a new one somehow but I don't currently see where this makes sense with the documented behavior of the existing listeners.
          Hide
          Jesse Kuhnert added a comment -

          I don't think I understand the issue with this one.

          The user "session" - which I'm assuming is not controlled by your activateExternalPage method should have nothing to do with whatever you do in there...Ie why aren't you able to validate your users permission to see a page in validate() alone ?

          Show
          Jesse Kuhnert added a comment - I don't think I understand the issue with this one. The user "session" - which I'm assuming is not controlled by your activateExternalPage method should have nothing to do with whatever you do in there...Ie why aren't you able to validate your users permission to see a page in validate() alone ?
          Jesse Kuhnert made changes -
          Fix Version/s 4.1.1 [ 12312021 ]
          Andreas Andreou made changes -
          Field Original Value New Value
          Link This issue duplicates TAPESTRY-209 [ TAPESTRY-209 ]
          Henri Dupre created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Henri Dupre
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development