Uploaded image for project: 'Tapestry'
  1. Tapestry
  2. TAPESTRY-977

XTile component incorrectly quotes request URLs

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.1
    • Fix Version/s: 4.1.1
    • Component/s: Contrib
    • Labels:
      None

      Description

      XTile.script file contains this function:

      function quoteUrl(text)

      { return escape(text).replace(/\+/g, '%2C').replace(/\"/g,'%22').replace(/\'/g, '%27'); }

      Which enocdes a '+' as %2C which decodes as a comma.

      The '%2C' should be '%2B'

      Perhaps the code should actually use the JavaScript encodeURI() or encodeURIComponent() functions. See:
      http://xkr.us/articles/javascript/encode-compare/

        Activity

        Hide
        jkuhnert Jesse Kuhnert added a comment -

        Refactored script to use encodeUri()

        Show
        jkuhnert Jesse Kuhnert added a comment - Refactored script to use encodeUri()
        Hide
        rholmes Ryan Holmes added a comment -

        This doesn't appear to be fixed in the 4.0 branch. XTile is probably more important for 4.0 than for 4.1, so can someone apply the fix there as well?

        Show
        rholmes Ryan Holmes added a comment - This doesn't appear to be fixed in the 4.0 branch. XTile is probably more important for 4.0 than for 4.1, so can someone apply the fix there as well?

          People

          • Assignee:
            Unassigned
            Reporter:
            paulf Paul Field
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development