Tapestry
  1. Tapestry
  2. TAPESTRY-932

SimpleTableColumnComponent.html contains invalid CSS

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0.1
    • Fix Version/s: 4.1.1
    • Component/s: Contrib
    • Labels:
      None
    • Environment:
      Windows/Firefox

      Description

      Line 21 of SimpleTableColumnComponent.html refers to a nonexistent CSS attribute, "align". This causes any pages using the Table component with sortable columns to fail CSS validation.

      If "vertical-align" was intended, the CSS should be changed accordingly (probably "vertical-align: middle;").

      Since the style tag contains no other CSS, it might be preferable to remove it entirely and leave it to the user to set attributes for the .tableHeaderImage class.

        Activity

        Ryan Holmes created issue -
        Hide
        Brian K. Wallace added a comment -

        I'll look at this, but I'm thinking that fixing the CSS would be preferable to provide a 'sensible default'. If it's suitable for a majority of the users, yet overridable for the rest, it's a good thing in my opinion.

        Show
        Brian K. Wallace added a comment - I'll look at this, but I'm thinking that fixing the CSS would be preferable to provide a 'sensible default'. If it's suitable for a majority of the users, yet overridable for the rest, it's a good thing in my opinion.
        Hide
        Leonardo Quijano Vincenzi added a comment -

        But isn't local styles more relevant that CSS files? I'm thinking it may be not overridable if a local style is applied there.
        And... is it XHTML compatible?

        Show
        Leonardo Quijano Vincenzi added a comment - But isn't local styles more relevant that CSS files? I'm thinking it may be not overridable if a local style is applied there. And... is it XHTML compatible?
        Hide
        Brian K. Wallace added a comment -

        Embedded styles take priority over linked. That's the closest I can vouch for. Linked from two places? The second would override the first.. The problem with any CSS change combines "embedded vs. linked" as well as "users who do not use CSS themselves".

        Hadn't planned on looking just yet, but I did and see the style embedded which would always take precedence. I'll look at removing it.
        This also affects SimpleTableColumnFormComponent (Those are the only two which have embedded styles in framework or contrib)

        Show
        Brian K. Wallace added a comment - Embedded styles take priority over linked. That's the closest I can vouch for. Linked from two places? The second would override the first.. The problem with any CSS change combines "embedded vs. linked" as well as "users who do not use CSS themselves". Hadn't planned on looking just yet, but I did and see the style embedded which would always take precedence. I'll look at removing it. This also affects SimpleTableColumnFormComponent (Those are the only two which have embedded styles in framework or contrib)
        Brian K. Wallace made changes -
        Field Original Value New Value
        Fix Version/s 4.0.3 [ 12310994 ]
        Assignee Brian K. Wallace [ vaporrun ]
        Hide
        Brian K. Wallace added a comment -

        Removed embedded style

        Show
        Brian K. Wallace added a comment - Removed embedded style
        Brian K. Wallace made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Mark Thomas made changes -
        Workflow jira [ 12361796 ] Default workflow, editable Closed status [ 12567691 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12567691 ] jira [ 12590822 ]

          People

          • Assignee:
            Brian K. Wallace
            Reporter:
            Ryan Holmes
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development