Tapestry
  1. Tapestry
  2. TAPESTRY-851

DatePicker does not error when bound to values of wrong type

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: 4.1.2
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      OSX

      Description

      I mistakenly bound my DatePicker to a java.util.Calendar that was null. No errors or exceptions were thrown. One should add a instanceof test for java.util.Date and throw an IllegalArgumentException if the object is not null and the wrong type.

        Activity

        Hide
        Jesse Kuhnert added a comment -

        As it's an ognl issue I'm going to drop it here. If that particular issue still exists in OGNL it would be very easy to fix, so please file it in http://jira.opensymphony.com/browse/OGNL if the problem still exists.

        Show
        Jesse Kuhnert added a comment - As it's an ognl issue I'm going to drop it here. If that particular issue still exists in OGNL it would be very easy to fix, so please file it in http://jira.opensymphony.com/browse/OGNL if the problem still exists.
        Hide
        Ron Piterman added a comment -

        This is an OGNL issue - when ognl tries to assign Object of class Foo to property of incompatible type, it silently drops the value, so the property is never updated.
        I had this same issue when trying to set the "value" inside a For iteration to an incompatible property - the value is silently dropped - I think HLS had contacted the OGNL devs for that.

        Show
        Ron Piterman added a comment - This is an OGNL issue - when ognl tries to assign Object of class Foo to property of incompatible type, it silently drops the value, so the property is never updated. I had this same issue when trying to set the "value" inside a For iteration to an incompatible property - the value is silently dropped - I think HLS had contacted the OGNL devs for that.

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            phillip rhodes
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development