Tapestry
  1. Tapestry
  2. TAPESTRY-396

RequestLocaleManagerImpl: Change private members to protected, to enable overriding implementation

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1.2
    • Component/s: Framework
    • Labels:
      None

      Description

      in class org.apachetapestry.services.impl.RequestLocaleManagerImpl (and probably in other impl classes as well) all members are defined private, not allowing to override a method.

      So, one has to copy the class. this is very ugly practive.

      Change the private to protected to enable sound extention of such services.

        Activity

        Ron Piterman created issue -
        Jesse Kuhnert made changes -
        Field Original Value New Value
        Fix Version/s 4.1.2 [ 12312202 ]
        Jesse Kuhnert made changes -
        Resolution Incomplete [ 4 ]
        Status Open [ 1 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12322133 ] Default workflow, editable Closed status [ 12569054 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12569054 ] jira [ 12592062 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ron Piterman
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development