[TAPESTRY-2478] Non-private fields in Tapestry component classes should fail early, instead get confusing javassist.bytecode.DuplicateMemberException

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 5.0.13
• Fix Version/s: 5.0.14
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Howard Lewis Ship
• Created: 24/Jun/08 18:31
• Updated: 24/Jun/08 21:32
• Resolved: 24/Jun/08 21:32

Description

This feels like a regression, some step (the proper validation that fields are private) is being missed.

Somehow, we are making it to finish() even though some fields are not private:

Caused by: java.lang.RuntimeException: javassist.bytecode.DuplicateMemberException: duplicate method: <init> in com.formos.blog.pages.Login
at org.apache.tapestry5.internal.services.InternalClassTransformationImpl.addConstructor(InternalClassTransformationImpl.java:1357)
at org.apache.tapestry5.internal.services.InternalClassTransformationImpl.finish(InternalClassTransformationImpl.java:1300)
at org.apache.tapestry5.internal.services.ComponentClassTransformerImpl.transformComponentClass(ComponentClassTransformerImpl.java:163)