Tapestry
  1. Tapestry
  2. TAPESTRY-2471

Parameter fields that are updated during component event processing (such as a form submit) may not clear their values at the end of the request

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 5.0.13
    • Fix Version/s: 5.0.14
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      The logic for clearing a component parameter field is added as so:

      extend method: public void postRenderCleanup()
      if (! _$model_invariant)
      {
      model = _$model_default;
      _$model_cached = false;
      }

      The problem is that this postRenderCleanup() is invoked after the component finishes rendering. If a parameter is updated as part of a form submission, this code is not called, and the parameter value is left behind. This can lead to leaks, as the parameter value is not cleared before the page is returned to the pool.

      The solution is to extend the method containingPageDidDetach() as well.

        Activity

        Howard M. Lewis Ship created issue -
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.14 [ 12313214 ]
        Status In Progress [ 3 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12433772 ] Default workflow, editable Closed status [ 12568687 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568687 ] jira [ 12591715 ]

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development