[TAPESTRY-2315] InjectContainerWorker should use this or other local variable name than "container"

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0.11
• Fix Version/s: 5.0.12
• Component/s: tapestry-core
• Environment: any
• Assignee: Ted Steen
• Reporter: Wolfram Koska
• Created: 30/Mar/08 00:05
• Updated: 31/Mar/08 17:09
• Resolved: 31/Mar/08 17:09

Description

What I did:

@InjectContainer
private Field container;

Resulted in: container == null

The InjectContainerWorker uses "container" as the name of a temporary local variable, and the assignment is done to the field name:

builder.addln("%s = (%s) container;", fieldName, fieldType);

This resulted in:

container = (org.apache.tapestry.Field) container;

Thus my instance variable was never assigned to. Should probably be

builder.addln("this.%s = (%s) container;", fieldName, fieldType);

or use any other name for the temporary variable - might not be so uncommon for people to name the container "container", and can be very confusing.