[TAPESTRY-230] Ignored interruptedException prevents Janitorthread termination

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0, 3.0.1
• Fix Version/s: 3.0.5
• Component/s: Framework
• Environment: Tomcat 4 & 5 (on Windows platform)
• Assignee: Paul Ferraro
• Reporter: Martijn Stellinga
• Created: 25/Nov/04 14:13
• Updated: 30/Apr/06 16:44
• Resolved: 18/Mar/05 03:46

Description

The org.apache.tapestry.util.JanitorThread uses a waitForNextPass() function that makes it sleep for 30 seconds and then do another pass.
In this method an InterruptedException is caught and ignored. This prevents the thread from terminating normally when, for instance, a context is reloaded. See also http://java.sun.com/j2se/1.5.0/docs/guide/misc/threadPrimitiveDeprecation.html.

I think it would be better if the while-loop in the run() method exited when the wait() in waitfornextpass() method was interrupted.