Uploaded image for project: 'Tapestry'
  1. Tapestry
  2. TAPESTRY-230

Ignored interruptedException prevents Janitorthread termination

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0, 3.0.1
    • Fix Version/s: 3.0.5
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Tomcat 4 & 5 (on Windows platform)

      Description

      The org.apache.tapestry.util.JanitorThread uses a waitForNextPass() function that makes it sleep for 30 seconds and then do another pass.
      In this method an InterruptedException is caught and ignored. This prevents the thread from terminating normally when, for instance, a context is reloaded. See also http://java.sun.com/j2se/1.5.0/docs/guide/misc/threadPrimitiveDeprecation.html.

      I think it would be better if the while-loop in the run() method exited when the wait() in waitfornextpass() method was interrupted.

        Attachments

          Activity

            People

            • Assignee:
              pferraro Paul Ferraro
              Reporter:
              mstellinga Martijn Stellinga
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: