[TAPESTRY-2253] A brain dead implementation of toString() on a custom data object can cause the Required validator to throw a NullPointerExcepton

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 5.0.12
• Fix Version/s: 5.0.12
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Kristian Marinkovic
• Created: 12/Mar/08 18:50
• Updated: 16/Apr/08 01:42
• Resolved: 16/Apr/08 01:42

Description

the validate method of the Required validator contains following code line:

if (value == null || value.toString().equals(""))...

if the toString method returns null an exception will occur (happened to me accidentally )

this code line should at least be changed to:

if (value == null || "".equals(value.toString())... to prevent NPE