Tapestry
  1. Tapestry
  2. TAPESTRY-2201

LabeledPropertySelectionModel.isDisabled ignores underlying model

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
    • Fix Version/s: 4.1.6
    • Component/s: Core Components
    • Labels:
      None

      Description

      LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.

      public boolean isDisabled(int index) {
      return index == 0 && _option == null;
      }

      should be replaced with:

      public boolean isDisabled(int index) {
      return index == 0 ? _option == null : _model.isDisabled(index - 1);
      }

        Activity

        Daniel Caldeweyher created issue -
        Daniel Caldeweyher made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Minor [ 4 ]
        Daniel Caldeweyher made changes -
        Affects Version/s 4.1 [ 12310632 ]
        Affects Version/s 4.1.2 [ 12312202 ]
        Affects Version/s 4.1.3 [ 12312516 ]
        Affects Version/s 4.1.1 [ 12312021 ]
        Daniel Caldeweyher made changes -
        Summary LabeledPropertySelectionModel.isDisabled ignores undeling model LabeledPropertySelectionModel.isDisabled ignores underlying model
        Andreas Andreou made changes -
        Assignee Andreas Andreou [ andyhot ]
        Fix Version/s 4.1.6 [ 12312957 ]
        Hide
        Andreas Andreou added a comment -

        Fixed - nice catch, thx!

        Show
        Andreas Andreou added a comment - Fixed - nice catch, thx!
        Andreas Andreou made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Mark Thomas made changes -
        Workflow jira [ 12424540 ] Default workflow, editable Closed status [ 12567874 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12567874 ] jira [ 12591003 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        18h 59m 1 Andreas Andreou 27/Feb/08 23:50

          People

          • Assignee:
            Andreas Andreou
            Reporter:
            Daniel Caldeweyher
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development