Tapestry
  1. Tapestry
  2. TAPESTRY-2201

LabeledPropertySelectionModel.isDisabled ignores underlying model

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1, 4.1.1, 4.1.2, 4.1.3, 4.1.5
    • Fix Version/s: 4.1.6
    • Component/s: Core Components
    • Labels:
      None

      Description

      LabeledPropertySelectionModel.isDisabled only looks at the label, but not the underlying model.

      public boolean isDisabled(int index) {
      return index == 0 && _option == null;
      }

      should be replaced with:

      public boolean isDisabled(int index) {
      return index == 0 ? _option == null : _model.isDisabled(index - 1);
      }

        Activity

        Hide
        Andreas Andreou added a comment -

        Fixed - nice catch, thx!

        Show
        Andreas Andreou added a comment - Fixed - nice catch, thx!

          People

          • Assignee:
            Andreas Andreou
            Reporter:
            Daniel Caldeweyher
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development