Tapestry
  1. Tapestry
  2. TAPESTRY-2169

Create an ExceptionAnalysisDisplay component

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.10
    • Fix Version/s: 5.0.11
    • Component/s: None
    • Labels:
      None

      Description

      Move the guts of ExceptionReport into an ExceptionAnalysisDisplay component to enable reuse in our own custom ExceptionReport pages like so:

      <body>
      <t:if test="productionMode">
      <!-- Put our production-happy exception display in here -->
      </t:if>
      <t:unless test="productionMode">
      <!-- Display Tapestry's full-on exception info here -->
      <t:exceptionanalysisdisplay exception="prop:exception"/>
      </t:unless>
      </body>

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568800 ] jira [ 12590129 ]
        Mark Thomas made changes -
        Workflow jira [ 12423816 ] Default workflow, editable Closed status [ 12568800 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Status Reopened [ 4 ] Closed [ 6 ]
        Hide
        Howard M. Lewis Ship added a comment -

        Please add a new issue to cover this new desired functionality. I'm thinking a parameter on the compnent could control the verbosity of the output.

        Show
        Howard M. Lewis Ship added a comment - Please add a new issue to cover this new desired functionality. I'm thinking a parameter on the compnent could control the verbosity of the output.
        Geoff Callender made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Hide
        Geoff Callender added a comment -

        Thanks for doing ExceptionDisplay, but why not do a component that does ALL the non-production-mode stuff so we can put it in our own pages with a single line? eg.

        <t:exceptionandsessiondisplay exception="exception"/>

        For now we users still have to copy the part that gets the session attributes, which we may have to keep up-to-date as T5 progresses, eg.

        <h1 class="t-exception-report">An unexpected application exception has occurred.</h1>

        <t:exceptiondisplay exception="exception"/>

        <div class="t-env-data">
        <h2>Request</h2>
        <t:renderobject object="request"/>

        <t:if test="hasSession">
        <h2>Session</h2>
        <dl>
        <t:loop source="session.attributeNames" value="attributeName">
        <dt>$

        {attributeName}

        </dt>
        <dd>
        <t:renderobject object="attributeValue"/>
        </dd>
        </t:loop>
        </dl>
        </t:if>
        </div>

        Show
        Geoff Callender added a comment - Thanks for doing ExceptionDisplay, but why not do a component that does ALL the non-production-mode stuff so we can put it in our own pages with a single line? eg. <t:exceptionandsessiondisplay exception="exception"/> For now we users still have to copy the part that gets the session attributes, which we may have to keep up-to-date as T5 progresses, eg. <h1 class="t-exception-report">An unexpected application exception has occurred.</h1> <t:exceptiondisplay exception="exception"/> <div class="t-env-data"> <h2>Request</h2> <t:renderobject object="request"/> <t:if test="hasSession"> <h2>Session</h2> <dl> <t:loop source="session.attributeNames" value="attributeName"> <dt>$ {attributeName} </dt> <dd> <t:renderobject object="attributeValue"/> </dd> </t:loop> </dl> </t:if> </div>
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 5.0.11 [ 12312968 ]
        Resolution Fixed [ 1 ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Geoff Callender made changes -
        Field Original Value New Value
        Description Move the guts of ExceptionReport into an ExceptionAnalysisDisplay component to enable reuse in our own custom ExceptionReport pages like so:

            <body>
                <t:if test="productionMode">
                    <!-- Put our production-happy exception display in here -->
                </t:if>
                <t:unless test="productionMode">
                    <!-- Display Tapestry's full-on exception info here in here -->
                    <t:exceptionanalysisdisplay exception="prop:exception"/>
                </t:unless>
            </body>

        Move the guts of ExceptionReport into an ExceptionAnalysisDisplay component to enable reuse in our own custom ExceptionReport pages like so:

            <body>
                <t:if test="productionMode">
                    <!-- Put our production-happy exception display in here -->
                </t:if>
                <t:unless test="productionMode">
                    <!-- Display Tapestry's full-on exception info here -->
                    <t:exceptionanalysisdisplay exception="prop:exception"/>
                </t:unless>
            </body>

        Geoff Callender created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Geoff Callender
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development