Tapestry
  1. Tapestry
  2. TAPESTRY-2112

Tapestry should use ValueEncoders, not simple type coercion, to convert between event context values, URL strings, and event method handler parameters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.10
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Currently (5.0.10-SNAPSHOT), Tapestry uses the TypeCoercer to convert such values, such as when building an event context or a page activation context.

      We need a service to which we can contribute ValueEncoders that can be used instead of TypeCoercer.

      This will open up a lot of possibilities in terms of automatically converting Hibernate entities to primary keys and back.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568052 ] jira [ 12590021 ]
        Mark Thomas made changes -
        Workflow jira [ 12422588 ] Default workflow, editable Closed status [ 12568052 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.10 [ 12312936 ]
        Status In Progress [ 3 ] Closed [ 6 ]
        Hide
        Howard M. Lewis Ship added a comment -

        Came out nicely, a follow on will be to add automatic value encoding for Hibernate entities (to tapestry-hibernate).

        Show
        Howard M. Lewis Ship added a comment - Came out nicely, a follow on will be to add automatic value encoding for Hibernate entities (to tapestry-hibernate).
        Hide
        Howard M. Lewis Ship added a comment -

        It would also be nice if default PrimaryKeyEncoders were based on ValueEncoders (which would often be a wrapper around TypeCoercer).

        Show
        Howard M. Lewis Ship added a comment - It would also be nice if default PrimaryKeyEncoders were based on ValueEncoders (which would often be a wrapper around TypeCoercer).
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Hide
        Howard M. Lewis Ship added a comment -

        An, of course, the fall back for when there isn't a type-specific ValueEncoder is to use a wrapper around TypeCoercer.

        Show
        Howard M. Lewis Ship added a comment - An, of course, the fall back for when there isn't a type-specific ValueEncoder is to use a wrapper around TypeCoercer.
        Howard M. Lewis Ship created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development