Tapestry
  1. Tapestry
  2. TAPESTRY-2071

Validators using Regexps shouldn't use the pool-based PatternMatcher

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.3
    • Fix Version/s: 4.1.5
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      any

      Description

      PatternMatcher pools regular expression which makes sense when used as a member of (singleton-) services.
      Validators on the other hand, are normally used as leight-weight beans not surviving a request cycle. Creating
      a commons-pool for each of them doesn't seem right - and causes trouble when commons-pool breaks.
      Thus validators should use java.util.regex.Pattern directly.

        Activity

        Hide
        Marcus Schulte added a comment -

        missed ValidatorFactoryImpl, line 57

        Show
        Marcus Schulte added a comment - missed ValidatorFactoryImpl, line 57

          People

          • Assignee:
            Marcus Schulte
            Reporter:
            Marcus Schulte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development