[TAPESTRY-1972] Client persistence bug - user typing lost

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 5.0.6
• Component/s: tapestry-core
• Environment: Safari, OS X, JBoss 4.2.1
• Assignee: Howard Lewis Ship
• Reporter: Geoff Callender
• Created: 11/Dec/07 11:27
• Updated: 12/Aug/09 03:59
• Resolved: 29/Feb/08 18:24

Description

The user loses the changes they typed into an "input" or "edit" page if an error is recorded by onSuccess() AND the page is dealing with a client persisted object. The page is redisplayed OK, with error, but with the previous values!!!

The user's changes aren't lost if
(a) I move the work that finds the error from onSuccess() into onValidate() - this fixes all TextField components but does not fix Select, DateField, checkbox, or expansions; or
(b) I add a simple client-persisted field to the page - remarkably this fixes; or
(c) I replace client persistence with session persistence.

To illustrate the problem, it's just like the example from http://tapestry.apache.org/tapestry5/tapestry-core/guide/validation.html, which contains these excerpts:

@Persist
private String _userName;

private String _password;

String onSuccess()
{
if (!_authenticator.isValid(_userName, _password))

{ _form.recordError(_passwordField, "Invalid user name or password."); return null; }

return "PostLogin";
}

except that instead of a single field, _userName, I am persisting a whole object, _user:

@Persist("client")
private User _user;

and in the template we refer to its fields, eg:

<input t:type="TextField" t:id="firstName" value="user.firstName" ...

If the user types a value into firstName, but the onSuccess() method records an error, then the user loses what they typed.

However, if I add another field to the page then everything works!

@Persist("client")
private String _aField;

<input t:type="TextField" t:id="aField" value="aField" ...

Alternatively, it works if I do either of the other 2 things - use session persistence or move all logic into onValidate().

Issue Links

• is related to: TAP5-812 The input validation documentation incorrectly shows validation occuring in the success event handler method