Tapestry
  1. Tapestry
  2. TAPESTRY-197

Leading & trailing spaces not trimmed from ValidField

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.0
    • Fix Version/s: 4.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Operating System: Other
      Platform: All

      Description

      The contract for the IValidator interface states that the input parameter for
      toObject should already be trimmed on entry. This does not happen. I suspect
      that getParameter in RequestContext should be modified to trim the value. Also,
      what about getParameters?
      This bug causes problems with the numeric validators, string validators (eg,
      required, min. length), etc.

        Activity

        Hide
        Howard M. Lewis Ship added a comment -

        Changing getParameter() is a very bad idea; much better to do the actual trimming inside ValidField or AbstractTextField.

        Show
        Howard M. Lewis Ship added a comment - Changing getParameter() is a very bad idea; much better to do the actual trimming inside ValidField or AbstractTextField.
        Hide
        Jesse Kuhnert added a comment -

        ValidField is now gone.

        Show
        Jesse Kuhnert added a comment - ValidField is now gone.

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            DWright
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development