Tapestry
  1. Tapestry
  2. TAPESTRY-1964

Constant not used from app-name in TapestryModule

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.0.6
    • Fix Version/s: 5.0.15
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      I had some trobubles with @Symbol annotation ...
      and ran into following code in TapestryModule

      @Inject @Value("WEB-INF/$

      {tapestry.app-name}

      .properties") String appCatalog

      I changed it to
      @Inject @Value("WEB-INF/$

      {"+InternalConstants.TAPESTRY_APP_NAME_SYMBOL+"}

      .properties") String appCatalog

      and then into
      @Inject @Symbol(InternalConstants.TAPESTRY_APP_NAME_SYMBOL) String appName
      ....
      String appCatalog = "WEB-INF/"appName".properties";

      not that this is a big deal or anything, just a small fix...

        Activity

        Davor Hrg created issue -
        Hide
        Davor Hrg added a comment -

        the fix for current trunk

        Show
        Davor Hrg added a comment - the fix for current trunk
        Davor Hrg made changes -
        Field Original Value New Value
        Attachment TAPESTRY-1964.patch [ 12371107 ]
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.0.8 [ 12312898 ]
        Fix Version/s 5.0.7 [ 12312802 ]
        Hide
        Howard M. Lewis Ship added a comment -

        We don't define a fix version until a fix is committed.

        Show
        Howard M. Lewis Ship added a comment - We don't define a fix version until a fix is committed.
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.0.8 [ 12312898 ]
        Howard M. Lewis Ship committed 693311 (1 file)
        Reviews: none

        TAPESTRY-1964: Constant not used from app-name in TapestryModule

        Howard M. Lewis Ship made changes -
        Fix Version/s 5.0.15 [ 12313350 ]
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Assignee Howard M. Lewis Ship [ hlship ]
        Mark Thomas made changes -
        Workflow jira [ 12418707 ] Default workflow, editable Closed status [ 12568821 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568821 ] jira [ 12591854 ]

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Davor Hrg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development