Tapestry
  1. Tapestry
  2. TAPESTRY-1930

Render missing parameter names in different font and/or text style.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0.6
    • Fix Version/s: 5.0.11
    • Component/s: Framework
    • Labels:
      None

      Description

      The error message for indicating missing required component parameters could benefit by making the parameter names stand out from the error message better. For example, failing to bind the "object" parameter of the BeanEditForm component yields the following message:

      "Parameter(s) object are required for org.apache.tapestry.corelib.components.BeanEditForm, but have not been bound."

      That entire message renders in a uniform, italicized font. It is simple to misread that message though and not realize that the missing parameter name is "object". If "object" were rendered in a non-italicized font, in a fixed-width font, in bold, or any other differentiator to call attention to it, the error message could be greatly enhanced.

        Activity

        Hide
        Kevin Menard added a comment -

        Here's a patch for the issue. I just single-quoted the values as is done for other strings. I played with different fonts and weights, but they really didn't stand out. There still may be value in using different font colors, but this patch addresses the core issue.

        Show
        Kevin Menard added a comment - Here's a patch for the issue. I just single-quoted the values as is done for other strings. I played with different fonts and weights, but they really didn't stand out. There still may be value in using different font colors, but this patch addresses the core issue.

          People

          • Assignee:
            Kevin Menard
            Reporter:
            Kevin Menard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development