Tapestry
  1. Tapestry
  2. TAPESTRY-1688

the tapestry form.js script has an unnecessary call to eval

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.2, 4.1.3
    • Fix Version/s: 4.1.3
    • Component/s: None
    • Labels:
      None

      Description

      the function
      registerProfile:function(id, profile){
      if (!this.forms[id])

      { dojo.raise("registerProfile(" + id + ") No form previously registered with that id."); return; }

      this.forms[id].profiles.push(eval(profile));
      }

      has an unnecessary call to eval since profile is already a js object

      1. form.js.diff
        0.8 kB
        Andrea Chiumenti

        Activity

        Hide
        Andrea Chiumenti added a comment -

        this patch fixes the problem

        Show
        Andrea Chiumenti added a comment - this patch fixes the problem

          People

          • Assignee:
            Unassigned
            Reporter:
            Andrea Chiumenti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development