Tapestry
  1. Tapestry
  2. TAPESTRY-1597

When a List is converted to a SelectModel, the keys are converted unnecessarily to strings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.0.6
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Same thing as the Map problem, but a one liner:

      org.apache.tapestry.internal.TapestryInternalUtils, line 234:

      public static OptionModel toOptionModel(Object input)

      { String value = (input != null ? String.valueOf(input) : ""); return new OptionModelImpl(value, false, value); // <-- should be value, false, input (and perhaps rename value to label for consistency) }

      Cheers,
      Nick.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12567939 ] jira [ 12591060 ]
        Mark Thomas made changes -
        Workflow jira [ 12406976 ] Default workflow, editable Closed status [ 12567939 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Assignee Howard M. Lewis Ship [ hlship ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.0.6 [ 12312544 ]
        Nick Westgate made changes -
        Field Original Value New Value
        Attachment TAPESTRY-1597.patch [ 12364210 ]
        Nick Westgate created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Nick Westgate
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development