Tapestry
  1. Tapestry
  2. TAPESTRY-1579

Allow multiple BeanEditor components within a form

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.5
    • Fix Version/s: 5.0.6
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      We do a lot of work with content management systems and thus use forms a lot. I would really like to use BeanEditForm as it's got a lot of great features but it has a couple limitations that, at this point, means we won't be able to use it.

      The first is that it creates it's own form which limits being able to use it in conjunction with more complicated forms. Perhaps add a boolean 'createForm' parameter which defaults to true and indicates whether or not to render a form. Or better still, detect whether the component is rendering in a form and only create one if there is no outer form. Or both and have the behavior default to the latter.

      The second is that I have no control over the rendering of the html around the fields. It would be really useful if there was either an override I contribute to or a parameter to provide a renderer or both. If I had that then I could use beaneditform and know that the structure of the fields and labels would be consistent with the rest of the system.

        Activity

        Hide
        Dan Adams added a comment -

        Also, another showstopper is that it renders it's own submit button. I need to be able to use beaneditform and have it just render the fields without a form or submit button and be able to control the html surrounding the fields.

        Show
        Dan Adams added a comment - Also, another showstopper is that it renders it's own submit button. I need to be able to use beaneditform and have it just render the fields without a form or submit button and be able to control the html surrounding the fields.
        Hide
        Howard M. Lewis Ship added a comment -

        I totally agree; it's been in the back of my mind to split out BeanEditForm into BeanEditor (very resuable) plus a BeanEditForm wrapper for convenience.

        In addition, creating an EditProperty component (as the basis for BeanEditor) would make reuse even easier.

        Show
        Howard M. Lewis Ship added a comment - I totally agree; it's been in the back of my mind to split out BeanEditForm into BeanEditor (very resuable) plus a BeanEditForm wrapper for convenience. In addition, creating an EditProperty component (as the basis for BeanEditor) would make reuse even easier.
        Hide
        Howard M. Lewis Ship added a comment -

        Came out Sweet!

        Show
        Howard M. Lewis Ship added a comment - Came out Sweet!

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Dan Adams
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development