Tapestry
  1. Tapestry
  2. TAPESTRY-1316

Address class loader issues inside JBoss

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.3
    • Fix Version/s: 5.0.3
    • Component/s: tapestry-ioc
    • Labels:
      None

      Description

      As per the comment on addClassLoader, if the class loader hierarchy is not a flat line then the classloaders can be lost.

      1. TAP-1316.patch
        3 kB
        Ben Sommerville

        Issue Links

          Activity

          Ben Sommerville created issue -
          Hide
          Ben Sommerville added a comment -

          Patch to copy with classloaders with tree structures.

          What it does is track the leaf classloader of each branch in the tree (that we have seen). When a new classloader is added we check to see if it is a child of an existing leaf. If so we replace the existing leaf. If not we add a new leaf.

          I have tested this under JBoss & it fixed the problem that I was having. It hasn't been tested under any other container.

          Show
          Ben Sommerville added a comment - Patch to copy with classloaders with tree structures. What it does is track the leaf classloader of each branch in the tree (that we have seen). When a new classloader is added we check to see if it is a child of an existing leaf. If so we replace the existing leaf. If not we add a new leaf. I have tested this under JBoss & it fixed the problem that I was having. It hasn't been tested under any other container.
          Ben Sommerville made changes -
          Field Original Value New Value
          Attachment TAP-1316.patch [ 12352575 ]
          Howard M. Lewis Ship made changes -
          Link This issue relates to TAPESTRY-1321 [ TAPESTRY-1321 ]
          Hide
          Howard M. Lewis Ship added a comment -

          Ben — you are the man! This really cleaned up a lot of ugliness deploying and redeploying inside JBoss.

          Show
          Howard M. Lewis Ship added a comment - Ben — you are the man! This really cleaned up a lot of ugliness deploying and redeploying inside JBoss.
          Howard M. Lewis Ship made changes -
          Summary ClassFactoryClassPool doesn't cope with ClassLoaders that have a tree structure. Address class loader issues inside JBoss
          Howard M. Lewis Ship made changes -
          Fix Version/s 5.0.3 [ 12312338 ]
          Assignee Howard M. Lewis Ship [ hlship ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          Mark Thomas made changes -
          Workflow jira [ 12398717 ] Default workflow, editable Closed status [ 12567926 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12567926 ] jira [ 12591818 ]

            People

            • Assignee:
              Howard M. Lewis Ship
              Reporter:
              Ben Sommerville
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development